ANW-1940 port resources spec to capybara #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianzelip
requested changes
Mar 12, 2024
brianzelip
reviewed
Mar 12, 2024
thimios
force-pushed
the
ANW-1940-resources-spec
branch
from
c937cd7
to
3a4a6cb
Compare
brianzelip
reviewed
Mar 12, 2024
brianzelip
reviewed
Mar 12, 2024
thimios
force-pushed
the
ANW-1940-resources-spec
branch
from
3a4a6cb
to
f7ce3e4
Compare
brianzelip
previously approved these changes
Mar 13, 2024
thimios
force-pushed
the
ANW-1940-resources-spec
branch
from
3564bac
to
cc3a4d2
Compare
thimios
force-pushed
the
ANW-1940-resources-spec
branch
from
cc3a4d2
to
98ef523
Compare
thimios
force-pushed
the
ANW-1940-resources-spec
branch
from
98ef523
to
16a2e24
Compare
brianzelip
requested changes
Apr 16, 2024
There was a problem hiding this comment.
@thimios Phew that was a big one, nice work! I noticed a couple points for follow up and added some of the solution pointers.
| select_repository(@repository) | ||
| end | ||
|
|
||
| it 'can create a new digital object instance with a note to a resource' do |
There was a problem hiding this comment.
I think this test probably belongs with the resources_spec.rb file since it's testing the ability of a Resource record to create a digital object instance for itself.
The description might also read 'can create and link a new digital object instance with a note'.
thimios
force-pushed
the
ANW-1940-resources-spec
branch
from
316d8df
to
944dd26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/browse/ANW-1940
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: