Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1931 locations spec #3165

Merged
merged 1 commit into from Apr 16, 2024
Merged

ANW-1931 locations spec #3165

merged 1 commit into from Apr 16, 2024

Conversation

thimios
Copy link
Collaborator

@thimios thimios commented Mar 19, 2024

Description

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1931

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thimios thimios force-pushed the ANW-1931-locations_spec.rb branch from 149c5db to ce4cc76 Compare April 4, 2024 14:49
@thimios thimios marked this pull request as ready for review April 12, 2024 17:09
brianzelip
brianzelip previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work combining pairs of tests into one.

frontend/spec/features/locations_spec.rb Show resolved Hide resolved
brianzelip
brianzelip approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@brianzelip brianzelip merged commit 43a5561 into master Apr 16, 2024
21 checks passed
@brianzelip brianzelip deleted the ANW-1931-locations_spec.rb branch April 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianzelip brianzelip brianzelip approved these changes

@donaldjosephsmith donaldjosephsmith Awaiting requested review from donaldjosephsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thimios @brianzelip