ANW-1919 port agents specs to capybara #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thimios
force-pushed
the
ANW-1919-frontend-spec-selenium-spec-agents_spec.rb
branch
3 times, most recently
from
ecc1150
to
c815503
Compare
thimios
force-pushed
the
ANW-1919-frontend-spec-selenium-spec-agents_spec.rb
branch
3 times, most recently
from
1889f80
to
4e08004
Compare
thimios
force-pushed
the
ANW-1919-frontend-spec-selenium-spec-agents_spec.rb
branch
from
4e08004
to
f2c0c35
Compare
brianzelip
requested changes
Apr 26, 2024
| end | ||
|
|
||
| it 'hides agent_other_agency_codes from form' do | ||
| expect(page).to_not have_css '#agent_person_agent_sources' |
There was a problem hiding this comment.
The selector here should read '#agent_person_agent_other_agency_codes'.
There was a problem hiding this comment.
This is actually a duplicate example that I will remove. But you are right there that it needs to check that no '#agent_person_agent_other_agency_codes' are there, which is actually already done three examples above. @brianzelip
thimios
force-pushed
the
ANW-1919-frontend-spec-selenium-spec-agents_spec.rb
branch
from
f2c0c35
to
8a17bd3
Compare
brianzelip
deleted the
ANW-1919-frontend-spec-selenium-spec-agents_spec.rb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/browse/ANW-1919
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: