Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1843 Exclude URIs from EAD export #3228

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

thimios
Copy link
Collaborator

@thimios thimios commented Jun 4, 2024

Description

Related JIRA Ticket or GitHub Issue

ANW-1843

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thimios thimios marked this pull request as ready for review June 4, 2024 15:45
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thimios two small spec followups; only the backend/spec/export_ead_spec.rb change is necessary, but the frontend spec could probably stand to be changed as well.

backend/spec/export_ead_spec.rb Outdated Show resolved Hide resolved
frontend/spec/features/resources_spec.rb Outdated Show resolved Hide resolved
@cdibella cdibella modified the milestone: 3.5.1 Jun 5, 2024
@thimios thimios requested a review from brianzelip June 5, 2024 18:46
@donaldjosephsmith donaldjosephsmith merged commit 0185b89 into master Jun 5, 2024
21 of 22 checks passed
@donaldjosephsmith donaldjosephsmith deleted the ANW-1843-reimplemenation branch June 5, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants