Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker setup by adding archivy-lite option / ability to change config #15

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

Uzay-G
Copy link
Member

@Uzay-G Uzay-G commented Dec 4, 2021

This PR introduces several changes to the docker code:

  • clean up Dockerfile
  • remove healthcheck.sh (already handled in Archivy itself)
  • creation of a new Dockerfile-light to use Archivy with ripgrep, not ES
  • implementation of an easier way to add custom configuration, using an extra docker-compose file

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 4, 2021

I've tested this locally:

  • Dockerfile built image works with docker-compose.yml
  • Dockerfile.source ^^
  • Dockerfile-light works with docker-compose-light.yml
  • appending -f docker-compose.custom-config.yml to compose command, with the archivy_config/ directory setup, allows users to extend the configuration

Confirmation testing from someone else on this would be great.

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 6, 2021

@BrianGilbert this would make it much easier to do custom configuration on Docker. I'll merge it in once it's tested.

To test:

  • docker build --file ./Dockerfile . --build-arg VERSION=1.5 --output type=image,name=archivy or docker build --file ./Dockerfile.source . --build-arg VCS_REF=7bd0c6ad9940502dc905a46e87f35585e6037048 --output type=image,name=archivy for source image.
  • copy the image name, and replace it in the docker-compose
  • docker-compose -f <docker-compose> -f docker-compose.custom-config.yml up

@Uzay-G
Copy link
Member Author

Uzay-G commented Dec 10, 2021

Merging in, will test it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant