Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to image upload #225

Merged
merged 5 commits into from
May 9, 2021
Merged

Improvements to image upload #225

merged 5 commits into from
May 9, 2021

Conversation

Uzay-G
Copy link
Member

@Uzay-G Uzay-G commented Apr 19, 2021

This implements a new config option, inside SCRAPING_CONF["save_images"] where images called in downloaded webpages are stored locally. I decided to set this to False by default.

@Uzay-G Uzay-G closed this Apr 19, 2021
@Uzay-G Uzay-G reopened this Apr 19, 2021
@Uzay-G Uzay-G marked this pull request as draft April 19, 2021 15:52
@Uzay-G
Copy link
Member Author

Uzay-G commented Apr 19, 2021

This is just a draft, I might try to add testing, and I also think that the code might be improved.

@srevinsaju I think you're right, this feature will be quite nice. Tell me what you think of the PR, when you can 😊

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #225 (b03d95f) into master (019d033) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   82.40%   82.82%   +0.41%     
==========================================
  Files          27       27              
  Lines        1967     2026      +59     
==========================================
+ Hits         1621     1678      +57     
- Misses        346      348       +2     
Impacted Files Coverage Δ
archivy/config.py 91.66% <100.00%> (+0.36%) ⬆️
archivy/data.py 90.86% <100.00%> (+0.69%) ⬆️
archivy/models.py 85.61% <100.00%> (+1.35%) ⬆️
tests/unit/test_models.py 100.00% <100.00%> (ø)
archivy/api.py 82.79% <0.00%> (-0.93%) ⬇️
archivy/forms.py 100.00% <0.00%> (ø)
tests/functional/test_routes.py 100.00% <0.00%> (ø)
tests/integration/test_api.py 99.21% <0.00%> (+0.03%) ⬆️
archivy/routes.py 88.88% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019d033...b03d95f. Read the comment docs.

@Uzay-G Uzay-G marked this pull request as ready for review May 9, 2021 16:31
@Uzay-G Uzay-G merged commit fa1de98 into master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant