Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave / better highlighting of when things aren't saved #292

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Conversation

Uzay-G
Copy link
Member

@Uzay-G Uzay-G commented Apr 21, 2022

@ZeroDawn0D brought it to my attention that the UX for signaling when content isn't saved, isn't complete enough. I think autosave / coloring in green / red the status icon when things aren't saved is a good step in this direction:

random

What do you think of this sort of change? @edditler i'd also be interested in what you think.

For now I did so it saves 2.5 changes after you edit, not sure if that's too little or not. I'll probably also make it so that you can enable this in the editor on top of the general archivy config.

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2022

Code Climate has analyzed commit f4c92dc and detected 0 issues on this pull request.

View more on Code Climate.

@Uzay-G
Copy link
Member Author

Uzay-G commented Apr 21, 2022

Also: should the default be autosave on or off?

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #292 (ac424b5) into master (ca6f0c3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ac424b5 differs from pull request most recent head f4c92dc. Consider uploading reports for the commit f4c92dc to get more accurate results

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files          28       28           
  Lines        2525     2525           
=======================================
  Hits         2149     2149           
  Misses        376      376           
Impacted Files Coverage Δ
archivy/config.py 100.00% <ø> (ø)
archivy/routes.py 87.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec6f7f...f4c92dc. Read the comment docs.

@edditler
Copy link
Contributor

For now I did so it saves 2.5 changes after you edit

2.5 seconds, you mean? I think that's a sensible default. Could of course also be a config option. Is there a good way to safe after, let's say, X characters have changed?

Also: should the default be autosave on or off?

Personally, I would turn it on because I'm also using archivy-git, but turning it off is the better default imo.

I also like the colored indicator!

@Uzay-G
Copy link
Member Author

Uzay-G commented Apr 27, 2022

Cool, thanks for the feedback. Yeah I did mean 2.5 seconds haha

@Uzay-G Uzay-G merged commit 53fc8f1 into master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants