Add --no-prompt-ignore option

[lilydjwg]

closes #210

Checklist

• Admin:
  • No duplicate PRs
• Integration:
  • Update unit tests
  • Update shell completions
  • Update configuration file
• Documentation:
  • Update usage function
  • Update mandoc
  • Update readme
  • Update locales
• Release:
  • Update change log
  • Update DOWNGRADE_VERSION

Description

What do you think about this? Or a better option name?

I'd like to have the maintainers' options before finishing the checklist.

[pbrisbin]

The only thing I can think of is if we'd want to extend this functionality, for example to allow adding to ignore without prompting. --no-prompt-ignore makes sense to me as "don't prompt to ignore" but it could also be interpreted as "just ignore without prompting". So I wonder if we'd rather have something like --ignore=never|always|prompt with --ignore=prompt being the default.

WDYT?

[atreyasha]

Thanks @lilydjwg for starting the PR!

Agree with @pbrisbin, makes sense to be explicit and have these three possibilities.

[lilydjwg]

I've changed it to be --ignore never|always|prompt, with a space instead of an equal sign because the option parser doesn't support =.

[atreyasha]

Tried some high-level tests of a4fa367 and it works fine. I would say we are good to proceed with next steps in the checklist, which I would be glad to help with.

WDYT?

[lilydjwg]

Hi, I ended up doing more than adding the options: the zsh completion and zh_CN translations have been updated too. I can make them separate pull requests if you prefer.

I can rebase the commits if you want.

[atreyasha]

Wow thanks for tackling almost everything!

Just a few remaining points that I listed in my review, with the tests being the most important remaining bit.

I can rebase the commits if you want.

Yes, a rebase would be great!

[pbrisbin]

Awesome, thank you!