genfstab: fix duplicate subvol entries #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be inclined to just drop the addition of the subvol param entirely. |
|
I've removed the if statement entirely. Could you take a look? |
|
Well you can't remove the if statement entirely -- now you're treating btrfs subvolumes as bind mounts. |
|
Whoops, you're right. I've added a check to make sure fstype is not btrfs. |
falconindy
reviewed
Jan 21, 2020
|
..and this should all be a single commit. |
|
Done. |
Options parsed from findmnt may already have the subvol option, so appending the subvol option is unnecessary. Fixes FS#65003 Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
|
Apologies for letting this drop off the radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options parsed from findmnt may already have the subvol option, so we
check if "subvol=" is in $opt before appending onto it.
Fixes FS#65003