Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to enable periodic TRIM for btrfs #1837

Closed
kojq opened this issue May 24, 2023 · 2 comments · Fixed by #2109
Closed

No need to enable periodic TRIM for btrfs #1837

kojq opened this issue May 24, 2023 · 2 comments · Fixed by #2109

Comments

@kojq
Copy link

kojq commented May 24, 2023 •
edited

Btrfs async discard has been enabled since the 6.2 kernel. Consequently, I suggest not enabling the fstrim.timer (periodic TRIM) for btrfs.
@kojq kojq changed the title Remove enable_periodic_trim No need to enable periodic TRIM for btrfs May 24, 2023
@lavafroth
Copy link
Contributor

lavafroth commented Jul 2, 2023 •
edited

Thanks! This appears to be enabled by default. For everyone's reference, here is the source. Maybe someone can write a PR to change this behavior.

This was referenced Sep 24, 2023
Closed
Closed
@Torxed
Copy link
Member

Torxed commented Sep 25, 2023

Thanks! This appears to be enabled by default. For everyone's reference, here is the source. Maybe someone can write a PR to change this behavior.

We need to change it, only for BTRFS it seems.

@Torxed Torxed mentioned this issue Sep 25, 2023
Merged
archlinux-github pushed a commit to archlinux/infrastructure that referenced this issue Sep 26, 2023
@foutrelis
install_arch: don't enable fstrim.timer (unneeded)
8915555 
Since Linux 6.2, Btrfs enables asynchronous trimming in its mount flags.

[1] archlinux/archinstall#1837
[2] torvalds/linux@63a7cb130718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabled fstrim on BTRFS by default archlinux/archinstall
3 participants
@Torxed @kojq @lavafroth