Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission flags on all the log files created #1440

Merged
merged 19 commits into from
Aug 28, 2022
Merged

Fix permission flags on all the log files created #1440

merged 19 commits into from
Aug 28, 2022

Conversation

Torxed
Copy link
Member

@Torxed Torxed commented Aug 28, 2022

PR Description:

Technically, the issue is already fixed in the huge re-work of the partitioning menu.
But while verifying I decided to clean up the permissions on the different files.

This should ensure that if user configuration files are copied, that they don't carry with them insecure read permissions.
I left the install.log with global read on purpose as the file is meant for debug purposes and should never contain sensitive information. If or when it does, it in of itself should be considered a security issue and be resolved. Changing permissions on the file won't change much when the real issue is when users post it - which they can and will anyway.

Tests and Checks

  • I have tested the code!

@Torxed Torxed changed the title Fix 1062 Fix permission flags on all the log files created Aug 28, 2022
@Torxed Torxed merged commit 13703fb into master Aug 28, 2022
@Torxed Torxed deleted the fix-1062 branch August 28, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant