Modify "Española" to "Español" #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@victorbnl It will have been a mistake by the author who does not speak Spanish like us. |
|
Yep that's what I came to think eventually |
|
@victorbnl What happened? |
|
Well, I deleted my fork of the repository and I thought the pull request was going to stay open, as it used to on GitHub. |
|
I think the PR is mergeable again now |
It's more an issue of: |
|
Ignore my previous comment, I am a bit tired and thought the two PR's I linked added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
So the translated name of Spanish is defined as "Española". It's pretty unnatural. At first, I thought it might be a shorthand for something like "la idioma española" : "the Spanish language", which, while still being really strange, would make a little bit of sense. Nevertheless, when looking at the other languages' names, they don't seem to follow this "convention" : French is "Français" and not "Française", Russian is "Ruskij" and not "Ruskaja"...
Tests and Checks