Check if line begins with 'warning' before adding it to package info

[Lautron]

• This fix issue: archinstall won't start due to TypeError #1673

PR Description:

Skip lines from pacman -Q --info that begin with 'warning' before adding them to package info to avoid getting a TypeError.
The problem is explained with more detail on #1673

Tests and Checks

• I have tested the code!
  
  • Tested on live ISO

[Torxed]

Nice catch. I think a long term solution would be to modify the fix to fix all future possible "odd outputs" from pacman.
Would you mind changing the fix to:

- return LocalPackage(**package_info)
+ import dataclasses
+ return LocalPackage({field.name: package_info.get(field.name) for field in dataclasses.fields(LocalPackage)})

I'm no expert, but I think this would solve it.
It would iterate the fields we've defined in LocalPackage and only populate those fields. Any additional fields (added inte future in the pacman project) would be ignored, including warning: or info: or whatever it outputs :)

I can manually change the patch but to keep the credit of finding and fixing the bug you're free to change if you want to :)

[Lautron]

Nice catch. I think a long term solution would be to modify the fix to fix all future possible "odd outputs" from pacman. Would you mind changing the fix to:

- return LocalPackage(**package_info)
+ import dataclasses
+ return LocalPackage({field.name: package_info.get(field.name) for field in dataclasses.fields(LocalPackage)})

I'm no expert, but I think this would solve it. It would iterate the fields we've defined in LocalPackage and only populate those fields. Any additional fields (added inte future in the pacman project) would be ignored, including warning: or info: or whatever it outputs :)

I can manually change the patch but to keep the credit of finding and fixing the bug you're free to change if you want to :)

Hi there! Thanks for your feedback.

I think your suggestion to make the fix more future-proof is great. I will definitely keep that in mind for future contributions to open source.

I have just made the changes you suggested in a new commit. Thank you again for your help and for being such a supportive member of the open source community.

[Torxed]

Thank you for this one! Merged! :)