Move locales and cleanup menu #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have plans to combine sys-lang and sys-enc into a single option, see #1435 (comment). Would you please put more work into partitioning? The work you have put towards it is amazing but partitioning is still lacking when compared with |
|
I don't think it's a blocker for yours as the main goal here is to put the locals into a submenu.to create space in the global one |
|
It looks good to me! Do you mind fixing the conflicts? |
|
@Torxed should be ready now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to add new global menu items such as
Optimizationsand potentiallyAdvancedmore space is needed :)This PR:
set:prefix from the menu (@Torxed it feels more lightweight this way but if it looks odd then happy for suggestions)