Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i3.py #1839

Merged
merged 1 commit into from Jun 12, 2023
Merged

Update i3.py #1839

merged 1 commit into from Jun 12, 2023

Conversation

y9tr3ble
Copy link
Contributor

@y9tr3ble y9tr3ble commented May 26, 2023

Bug with the installation of the i3 tiling manager because of an extra comma in the file

  • This fix issue:

PR Description:

Removed the comma after the "dmenu" package, since it is the final package

	@property
	def packages(self) -> List[str]:
		return [
			'i3-wm',
			'i3lock',
			'i3status',
			'i3blocks',
			'xterm',
			'lightdm-gtk-greeter',
			'lightdm',
			'dmenu' # Removed comma
		]

Tests and Checks

  • [馃 ] I have tested the code!

Bug with the installation of the i3 tiling manager because of an extra comma in the file
@y9tr3ble y9tr3ble requested a review from Torxed as a code owner May 26, 2023 12:06
@Torxed
Copy link
Member

Torxed commented Jun 5, 2023

Hi.

While I'd be happy to merge this code - I don't see what bug this would cause?
Python doesn't care if there's trailing commas or not? Or did Python 3.11 get that nitpicky?

@y9tr3ble
Copy link
Contributor Author

y9tr3ble commented Jun 5, 2023

Python 3.10.10 is preinstalled in archiso, and apparently in this version, it reacts to this comma, because when I removed this comma, my installation started

@svartkanin
Copy link
Collaborator

Might it be that you were running an older version of archinstall, we did have a comma issue in i4 but that got resolved already

@Torxed
Copy link
Member

Torxed commented Jun 7, 2023

Might it be that you were running an older version of archinstall, we did have a comma issue in i4 but that got resolved already

This is what I was thinking as well, and the comma was in a different spot then. So updating would help.

@y9tr3ble
Copy link
Contributor Author

y9tr3ble commented Jun 7, 2023

I still think the comma shouldn't be there

@Torxed Torxed merged commit 1b0c8f3 into archlinux:master Jun 12, 2023
@y9tr3ble y9tr3ble deleted the patch-1 branch June 12, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants