Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Chinese, Japanese and Korean text menu layout #1945

Merged
merged 1 commit into from Jul 31, 2023
Merged

Improve the Chinese, Japanese and Korean text menu layout #1945

merged 1 commit into from Jul 31, 2023

Conversation

yetist
Copy link
Contributor

@yetist yetist commented Jul 22, 2023 •
edited

PR Description:

Improve the Chinese, Japanese and Korean text menu layout

Before this patch, menus in Korean language would not be aligned:

2023-07-30_16-13

After apply this patch, menus in Korean language are aligned:

2023-07-30_16-12

@yetist
Improve the Chinese, Japanese and Korean text menu layout
589f3d0 
Before this patch, menus in Korean language would not be aligned:

```
  Archinstall 언어            Korean (71%)
> Mirrors
  Locales                   Defined
  Disk configuration
  부트로더                      Systemd-boot
  스왑                        True
```

After apply this patch, menus in Korean language are aligned:

```
  Archinstall 언어          Korean (71%)
> Mirrors
  Locales                   Defined
  Disk configuration
  부트로더                  Systemd-boot
  스왑                      True
```
@yetist yetist requested a review from Torxed as a code owner July 22, 2023 11:05
@yetist
Copy link
Contributor Author

yetist commented Jul 30, 2023

Simplified Chinese

Before:
2023-07-30_16-15

After:
2023-07-30_16-17

@Torxed
Copy link
Member

Torxed commented Jul 30, 2023

Thank you for putting this work in, this looks way better.
Let me just run through this code a couple of installs and I'll merge it.

@Torxed Torxed merged commit d878496 into archlinux:master Jul 31, 2023
6 checks passed
@Torxed
Copy link
Member

Torxed commented Jul 31, 2023

Thanks for your efforts in this area, it really helps!

@yetist yetist deleted the pr/cjk-menu-text branch August 1, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torxed Torxed Awaiting requested review from Torxed Torxed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yetist @Torxed