Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CJK text alignment #2012

Merged
merged 3 commits into from Sep 16, 2023
Merged

Conversation

yetist
Copy link
Contributor

@yetist yetist commented Aug 15, 2023

PR Description:

Support CJK text alignment

@yetist yetist requested a review from Torxed as a code owner August 15, 2023 04:41
@yetist yetist changed the title Cjkjust Support CJK text alignment Aug 15, 2023
@yetist
Copy link
Contributor Author

yetist commented Aug 15, 2023

Before:
image

After:
image

@yetist yetist force-pushed the cjkjust branch 2 times, most recently from d048d5b to 4ad3f42 Compare August 15, 2023 04:51
@Torxed
Copy link
Member

Torxed commented Sep 13, 2023

Well done on all of this!

@svartkanin
Copy link
Collaborator

Should we maybe rename the clk to something more meaningful? If this turns out to affect other languages in the future then the name is not inclusive and both specific at the same time.
Would unicode make more sense here as that's what it's doing?

@yetist
Copy link
Contributor Author

yetist commented Sep 15, 2023

Should we maybe rename the clk to something more meaningful? If this turns out to affect other languages in the future then the name is not inclusive and both specific at the same time. Would unicode make more sense here as that's what it's doing?

How about using the following names?
_count_cjk_chars() -> _count_wchars()
cjk_ljust() -> unicode_ljust()
cjk_rjust() -> unicode_rjust()

@svartkanin
Copy link
Collaborator

Yes that'd be great

@svartkanin svartkanin merged commit 47ed711 into archlinux:master Sep 16, 2023
6 checks passed
@yetist yetist deleted the cjkjust branch September 18, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants