Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1973 - pipewire #2030

Merged

Conversation

svartkanin
Copy link
Collaborator

@svartkanin svartkanin commented Sep 3, 2023

This fixes:

The problem is caused by pipewire-jack vs jack2 and pipewire-media-session vs wireplumber, those packages cannot be installed alongside each other and a choice needs to be made when one of them is already installed.
pacstrap will prompt for a auto resolution

pipewire-jack and jack2 are in conflict (jack). Remove jack2? [y/N]

but the current implementation of SysCommand doesn't allow for any interactive behavior and also pacstrap dosn't have any flag to auto approve.

However, by simply changing the order of installation such that pipewire (if chosen as a menu option) will be installed first and any other packages that depend on it and/or bring jack2 into the mix can make use of the already installed packages.
Main pointpoints seem to be Gnome and firefox.

This isn't a perfect solution as the installation process shouldn't depend on the order of packages installed but it'll do the trick for now. A possible rewrite of SysCommand to allow for interactive behavior is probably a better way forward.

@Torxed
Copy link
Member

Torxed commented Sep 13, 2023

the current implementation of SysCommand doesn't allow for any interactive

It does, but it's a bit raw. But here's an example:

>>> import archinstall
>>> worker = archinstall.SysCommandWorker("/bin/bash -c 'read -p \"Enter name: \" username; echo \"$username\"'")
>>> worker.poll()
>>> worker
b'Enter name: '
>>> worker.write(b'anton\n', line_ending=False)
6
>>> worker.poll()
>>> worker
b'Enter name: anton\r\nanton\r\n'

SysCommand is just a wrapper around SysCommandWorker for quicker things such as doing ls or useradd, whereas SysCommandWorker can be used for interactive things :)

@svartkanin
Copy link
Collaborator Author

Ahhh neat didn't know that's already working! I may do some rework on rhis fix later but I wanna get it in now to unblock users

@svartkanin svartkanin merged commit 3ba1a37 into archlinux:master Sep 14, 2023
5 of 6 checks passed
@svartkanin svartkanin deleted the fix-1973-pipewire-installation branch September 14, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment