Fix broken action check #2060
Merged
Fix broken action check #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Torxed The check should finally work now, thanks for the approval.
It will verify that any languages changes have been "committed" running the
locales_generator.shscript. That should generate the most recent msgids for all languages so that they are always up to date. This should avoid conflicts more easily.Regarding the blobs, I'm not sure what the best way of excluding them would be (or if still needed with the check). We can place them in the .gitignore file, however, I'm wondering how we would then get them committed on a new release at all?