Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify json functions #2102

Merged
merged 1 commit into from Sep 24, 2023
Merged

Unify json functions #2102

merged 1 commit into from Sep 24, 2023

Conversation

svartkanin
Copy link
Collaborator

Housekeeping PR to make the definitions for configurations less complex

  • Remove __dump__ function support
  • Move all configuration relevant exports to json()
  • Remove json() function support from the table formatter

Torxed
Torxed approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@Torxed Torxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to verify thoroughly that nothing gets lost in reading/writing configs. Doesn't look like anything would be affected, but let's keep an eye on it before releasing :)

@svartkanin
Copy link
Collaborator Author

I'm happy to keep this back and only merge after release

@Torxed
Copy link
Member

Torxed commented Sep 24, 2023

Ah no go ahead, v2.6.1 is out so was more thinking to the next release, which likely isn't until next month :)

@Torxed Torxed merged commit 360a1b4 into archlinux:master Sep 24, 2023
6 checks passed
@svartkanin svartkanin deleted the refactor-json-fun branch September 24, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torxed Torxed Torxed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svartkanin @Torxed