Added a --skip-ntp parameter to deal with #2144 #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archinstall/lib/installer.py
Outdated
| while True: | ||
| if not _notified and time.time() - _started_wait > 5: | ||
| _notified = True | ||
| warn("Time syncronization not completing, while you wait - check the docs for workarounds: https://archinstall.readthedocs.io/") |
There was a problem hiding this comment.
Maybe add something like "(...) completing ,this could me an issue with your network/ntp/environment permissions, while you wait (...)" and also maybe link directly to the relevant section instead of the whole doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix issue:
PR Description:
Since certain network environments prohibit the default NTP, we might end up in a loop waiting for NTP to happen. Usually this can be resolved while the loop is "hanging", but no information is given about it.
This PR adds both a
warn()call notifying the user about the potential issue after 5 seconds, but also a flag to--skip-ntpwhich disables the check all together. This can be useful in environments where NTP is not available and time is instead synced manually.