Locale generator fixes #2422
Merged
Locale generator fixes #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le filenames better Don't mix tabs and spaces, use tabs, just like the main script
|
I wish there was a code style that we can automatically apply 😓 |
svartkanin
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Unify tab usage instead of mixing tabs and spaces.
Write variables better to not erroneously use a wrong variable, also quote them to handle filenames with whitespace better.
Finally, exit on error instead of ignoring issues.
Note that this breaks the current git master, as msgfmt has a fatal error in one of the language mutations.
That's an easy fix, but it's something to fix in the language files, not in the script.
Tests and Checks