Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues like typos and code style violations. #57

Merged
merged 3 commits into from Oct 20, 2020

Conversation

vamega
Copy link
Contributor

@vamega vamega commented Oct 20, 2020

Description

  • Fixes some of the code style to align with PEP-8 (respecting this projects overrides of PEP-8"

Bugs and Issues

How Has This Been Tested?

  • None
    If there is a good way to test these changes I'd like to hear that.

As an example:

Test Configuration:

  • Hardware: VirtualBox 6.1
  • Specific steps: Ran installer with additional packages nano and wget

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code to the best of my abilities
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • I have made corresponding changes to the documentation where possible/if applicable (N/A))

`suppress_errors` was previously spelt `surpress_errors`
@Torxed
Copy link
Member

Torxed commented Oct 20, 2020

I'll document the testing a bit better!

But in short, it's essentially just booting any ArchISO with python on it (should be default now days) and wget the zip of this branch (git works too, but it's not default on the ISO), unpacking it and running cp examples/guided.py ./ && python guided.py on the ISO in a VM :) I've got an automated build for it, but it currently only works on master. So there's still a lot of manual work on branches/PR's/bug-reports hehe.

This PR passes a default installation with all options enabled:

{
    "harddrive": {
    	"path": "/dev/sda",
    	"size": "5G",
        "encryption": true
    },
    "hostname": "testmachine",
    "mirrors" : {
    	"Sweden" : {
    		"https://archlinux.dynamict.se/$repo/os/$arch": true,
    		"https://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch": true
    	}
    },
    "packages": [
    	"nano"
    ],
    "profile": {
    	"path": "awesome"
    },
    "users": [
    	"anton"
    ]
}

(This is just an early mock-up of the declarative profiles that will be implemented, which should help support/community contributors to understand what a profile does.. for auditing purposes)

@Torxed Torxed merged commit 2fc51d5 into archlinux:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change the descriptoin of profiles
2 participants