fix running as non-root creates non-root files in the cpio #15
Conversation
| @@ -221,7 +221,7 @@ build_image() { | |||
| # If this pipeline changes, |pipeprogs| below needs to be updated as well. | |||
| find . -mindepth 1 -printf '%P\0' | | |||
| sort -z | | |||
| LANG=C bsdtar --null -cnf - -T - | | |||
| LANG=C bsdtar --uid 0 --gid 0 --null -cnf - -T - | | |||
| LANG=C bsdtar --uid 0 --gid 0 --null -cf - --format=newc @- | | |||
There was a problem hiding this comment.
dreisner suggested that this second line probably doesn't need the --uid/--gid, since it obviously doesn't work. should I remove those?
There was a problem hiding this comment.
Might want to let @esotericnonsense look over and ensure it doesn't break reproducability.
There was a problem hiding this comment.
dreisner suggested that this second line probably doesn't need the --uid/--gid, since it obviously doesn't work. should I remove those?
This second line looks weird to me, indeed.
There was a problem hiding this comment.
Might want to let @esotericnonsense look over and ensure it doesn't break reproducability.
I'm going to test it also. And is reproducibility :-)
There was a problem hiding this comment.
btw, doesn't the above sort -z also need a LANG=C option (just in case)?
There was a problem hiding this comment.
maybe this quick fix should've been released earlier, and then do major refactors later
|
🔢 ? |
|
#38 implements the same feature with some more changes. I'm closing this one and I'll evaluate the other to see if it doesn't break reproducibility. |
https://bugs.archlinux.org/task/65006