Add support for 16k pages in qtwebengine #1928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
qtwebengine-16k
branch
from
1c1d1c7
to
a59c75a
Compare
Signed-off-by: Yichao Yu <yyc1992@gmail.com>
yuyichao
force-pushed
the
qtwebengine-16k
branch
from
a59c75a
to
97f278f
Compare
kmihelich
added a commit
that referenced
this pull request
Aug 21, 2022
|
@kmihelich Thanks. Note that in qt6.4 the webview part of the patch can be dropped since it'll presumably be chromium 102 based (https://wiki.qt.io/QtWebEngine/ChromiumVersions has not been updated yet). However, the pdfium part of the patch still needs to be applied. Ref https://bugreports.qt.io/browse/QTBUG-105145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of chromium/chromium@a704c3a and is needed to make qtwebengine works on apple m1 hardware.