Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to extract arrays from PKGBUILD #85

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Allow to extract arrays from PKGBUILD #85

merged 1 commit into from
Nov 4, 2018

Conversation

renyuneyun
Copy link
Contributor

Close #67 ?

lilydjwg
lilydjwg requested changes Nov 4, 2018
View reviewed changes
Copy link
Member

@lilydjwg lilydjwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tempfile. There is no reason to specify an output file.
Use with with open.
Reexport via lilac2.api then via legacy lilaclib. (make sure pyflake passes)

@lilydjwg
Copy link
Member

lilydjwg commented Nov 4, 2018

Also, can you raise an error if bash fails or the variable isn't read?

@renyuneyun renyuneyun force-pushed the pkgbuild branch 2 times, most recently from 6e3060a to 9eeaff8 Compare November 4, 2018 11:50
@renyuneyun
Copy link
Contributor Author

Changed to use tempfile and with. Also slightly changed the function signature.

Exported in api and lilaclib. Not sure if there are any requirements in ordering.

Exception is raised by subprocess.run(), of type CalledProcessError, with stderr supplied

@lilydjwg lilydjwg merged commit b7a0db1 into archlinuxcn:master Nov 4, 2018
@renyuneyun renyuneyun deleted the pkgbuild branch October 28, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilydjwg lilydjwg lilydjwg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renyuneyun @lilydjwg