Allow passing flatListProps #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the windowSize property of FlatList to default 3.
Exilz
reviewed
Sep 21, 2017
src/Gallery.js
Outdated
| scrollViewStyle: {} | ||
| scrollViewStyle: {}, | ||
| flatListProps: { | ||
| windowSize: 3, |
There was a problem hiding this comment.
Maybe we should set this windowSize value directly where we render Flatlist to make sure this isn't overriden when the users use flatListProps prop.
Or, we would have to merge the default value and the user's one.
There was a problem hiding this comment.
Yup. Makes sense. The soonest I'll be able to fix this is on Monday.
Exilz
reviewed
Sep 25, 2017
src/Gallery.js
Outdated
| @@ -265,9 +267,12 @@ export default class Gallery extends PureComponent { | |||
| gestureResponder = {}; | |||
| } | |||
|
|
|||
| const flatListProps = Object.assign(DEFAULT_FLAT_LIST_PROPS, this.props.flatListProps) | |||
There was a problem hiding this comment.
Much better ! Could you use the spread operator here to keep the codebase more consistant ?
|
Look good, I'll test this on the demo and merge it tomorrow. |
|
Can you add it in the README's props table as well ? |
|
Great! Thanks! |
|
Any chance of pushing to npm, @Exilz ? |
|
@vbuch published as |
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the windowSize property of FlatList to default 3.
#19