Don’t use getItemLayout

[infostreams]

Same reason as meliorence/react-native-snap-carousel@ce3bf06

[Exilz]

Shipped in 2.1.5.

[vbuch]

Was this done because of an issue? Where can I see how to reproduce it? @Exilz @infostreams

[infostreams]

Well, it broke whenever you did the following:

1. Make a Gallery with a window size and an initialNumToRender

<Gallery
   {...props}
    flatListProps={{windowSize: 2, initialNumToRender: 1}}  
  />

2. Open the gallery, then close the gallery again
3. Open the gallery on an initialPage that is larger than your windowSize
4. Broken; your user sees a black screen because the item is never rendered.

[vbuch]

OK. Thank you. I'll take a look.
The reason for asking is the regression this has created in the lib. There were things that used to work and don't anymore.

[vbuch]

Well, I have a gallery of 4 items. I passed in windowSize: 2 with initialNumToRender: 1 and I have no issue browsing around and/or using initialPage when using 2.1.4.
We're using:
"react-native": "^0.49.3",
"react-native-image-gallery": "^2.1.4",

@infostreams

[infostreams]

Well perhaps I misremember the exact circumstances, but I'm not making up that it is (or was) broken:

facebook/react-native#1831
facebook/react-native#8607
facebook/react-native#13316
facebook/react-native#13202
meliorence/react-native-snap-carousel#238

[vbuch]

So there was never an issue reported for react-native-image-gallery? But you think the issue was that you needed to scroll for rendering to happen? I also cannot remember "the circumstances" but I remember I've seen this bug while debugging about #20 and it was something that was not a problem of react-native-image-gallery but in my app.

[vbuch]

@infostreams Here is the discussion on this. #20 (comment) Could you check and try to remember if it is the same issue?

[infostreams]

Not entirely sure why you are accusing me of making things up, but yes - one of the most commented on issues in React Native was also showing its ugly head in this repository. I'm sorry that you can't reproduce it, and I'm sorry that you are having issues with this.

I'm not sure if it's the same bug as #20, but the symptoms do look the same.

[vbuch]

Sorry. I'm not accusing anyone of anything. Just trying to make sure the lib works as expected. I see there is a regression and I am sure that it is fighting an issue that is not an issue with the lib but with the rest of people's apps. FlatList does some thing "afterinteraction". If you have something that blocks the queue, you wn't get a render. So... that's what the real problem is. It's a problem with usage and not with how the lib works.