Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shallowCompare with PureComponent? #122

Open
bd-arc opened this issue Aug 23, 2017 · 1 comment
Open

Replace shallowCompare with PureComponent? #122

bd-arc opened this issue Aug 23, 2017 · 1 comment
Labels
enhancement

Comments

@bd-arc
Copy link
Contributor

bd-arc commented Aug 23, 2017

It might be a good idea to replace shallowCompare with PureComponent, but will it work with dynamic data?

From React's doc:

If your objects contain complex data structures, it may produce false-negatives for deeper differences. Only extend PureComponent when you expect to have simple props and state.
@dohooo

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bd-arc @dohooo