Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zen3: added pku feature, GCC and Clang support #29

Merged
merged 3 commits into from
Apr 13, 2021
Merged

zen3: added pku feature, GCC and Clang support #29

merged 3 commits into from
Apr 13, 2021

Conversation

alalazo
Copy link
Member

@alalazo alalazo commented Mar 26, 2021

I just compiled the development version of GCC and:

znver3
        AMD Family 19h core based CPUs with x86-64 instruction set support. (This supersets BMI, BMI2, CLWB, F16C, FMA, FSGSBASE, AVX, AVX2, ADCX, RDSEED, MWAITX, SHA, CLZERO, AES, PCLMUL,
        CX16, MOVBE, MMX, SSE, SSE2, SSE3, SSE4A, SSSE3, SSE4.1, SSE4.2, ABM, XSAVEC, XSAVES, CLFLUSHOPT, POPCNT, RDPID, WBNOINVD, PKU, VPCLMULQDQ, VAES, and 64-bit instruction set
        extensions.)

It seems that zen3 has PKU, VPCLMULQDQ, VAES more with respect to zen2, so adding the missing one and support for GCC

@alalazo alalazo added the enhancement New feature or request label Mar 26, 2021
@alalazo alalazo requested review from boegel and tgamblin March 26, 2021 15:22
@alalazo
Copy link
Member Author

alalazo commented Mar 26, 2021

@amd-toolchain-support

@alalazo
Copy link
Member Author

alalazo commented Mar 26, 2021

I'm also compiling the latest LLVM to check support for that compiler too.

@alalazo alalazo mentioned this pull request Apr 13, 2021
Merged
@alalazo
Copy link
Member Author

alalazo commented Apr 13, 2021

To report on LLVM: the option is, as usual, the same as GCC (-march=znver3). As far as I can tell it's currently only on trunk, so I can either add an entry with support starting from 12.0: or wait for support to be added to a tagged version.

@alalazo alalazo changed the title zen3: added pku feature, GCC support zen3: added pku feature, GCC and Clang support Apr 13, 2021
@alalazo alalazo requested a review from becker33 April 13, 2021 17:12
@becker33 becker33 merged commit bc69b8d into master Apr 13, 2021
@alalazo alalazo deleted the zen3/adjustment_and_gcc branch April 14, 2021 08:03
@alalazo
Copy link
Member Author

alalazo commented Apr 14, 2021

Thanks!

@pelahi pelahi mentioned this pull request May 5, 2021
Closed
3 tasks
alalazo added a commit that referenced this pull request Oct 22, 2021
@alalazo
zen3: added pku feature, GCC and Clang support (#29)
682ac7a 
* zen3: added pku feature, GCC support

* zen3: adjusted GCC version with initial support

* zen3: added support for Clang
alalazo added a commit that referenced this pull request Oct 22, 2021
@alalazo
zen3: added pku feature, GCC and Clang support (#29)
9be4dfe 
* zen3: added pku feature, GCC support

* zen3: adjusted GCC version with initial support

* zen3: added support for Clang
@alalazo alalazo mentioned this pull request Jan 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becker33 becker33 becker33 approved these changes

@boegel boegel Awaiting requested review from boegel

@tgamblin tgamblin Awaiting requested review from tgamblin

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alalazo @becker33