Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: simplify parameters usage #181

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

fdymylja
Copy link
Contributor

This PR shrinks parameters.

@fdymylja fdymylja requested a review from edjroz July 12, 2022 17:52
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #181 (8d54416) into main (5bb7b4f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   56.42%   56.47%   +0.05%     
==========================================
  Files          15       15              
  Lines        1246     1243       -3     
==========================================
- Hits          703      702       -1     
+ Misses        495      494       -1     
+ Partials       48       47       -1     
Impacted Files Coverage Δ
x/gastracker/keeper/keeper.go 70.14% <100.00%> (+0.40%) ⬆️
x/gastracker/module/abci.go 81.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb7b4f...8d54416. Read the comment docs.

@fdymylja fdymylja merged commit 68a80f4 into main Jul 12, 2022
@fdymylja fdymylja deleted the fdymylja/refactor-parameters branch July 12, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants