change: move handling of tx fees and inflationary rewards to middlewares

[fdymylja]

closes: #192
closes: #194

[codecov]

Codecov Report

Merging #193 (868bafe) into main (547c9a5) will decrease coverage by 2.77%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   58.66%   55.89%   -2.78%     
==========================================
  Files          17       18       +1     
  Lines        1200     1238      +38     
==========================================
- Hits          704      692      -12     
- Misses        460      510      +50     
  Partials       36       36              

Impacted Files	Coverage Δ
x/gastracker/ante/fee_deduction.go	0.00% <0.00%> (ø)
x/gastracker/ante/tracking.go	100.00% <ø> (ø)
x/gastracker/keeper/grpc_query.go	0.00% <0.00%> (ø)
x/gastracker/module/abci.go	80.95% <50.00%> (-0.66%)	⬇️
x/gastracker/keeper/keeper.go	94.40% <80.00%> (-1.06%)	⬇️
app/ante.go	62.50% <100.00%> (ø)
app/app.go	90.23% <100.00%> (-0.03%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547c9a5...868bafe. Read the comment docs.

[edjroz]

Love the separation of concerns 🔥

[ParthDesai]

@fdymylja I do believe we would still need to transfer the inflationary reward from Fee collector to the gas tracker module account.

[fdymylja]

@fdymylja I do believe we would still need to transfer the inflationary reward from Fee collector to the gas tracker module account.

https://github.com/archway-network/archway/pull/193/files#diff-37079039d75251a7e8c59b88511e38f2833e47a680f7989fe74ba9a940fb2c1bR102 <= tx fees are transferred here.

https://github.com/archway-network/archway/pull/193/files#diff-d532f09edd56c8154bebc56d09a1569792c037fc476ae0b756e3a1f56ec39a65R52 <= inflationary rewards are being transferred here