Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM bindings #196

Merged
merged 1 commit into from
Jul 26, 2022
Merged

WASM bindings #196

merged 1 commit into from
Jul 26, 2022

Conversation

iTiky
Copy link
Contributor

@iTiky iTiky commented Jul 19, 2022

Custom Query and Msgs handling plugins added to give a contract ability to get and update its metadata.

  • App keepers initialization sequence changed to support custom plugins;
  • e2e tests added for the Voter contract to test bindings;

@iTiky iTiky requested a review from fdymylja July 19, 2022 12:50
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #196 (8823cad) into main (6bd62af) will increase coverage by 0.78%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   55.89%   56.68%   +0.78%     
==========================================
  Files          18       20       +2     
  Lines        1238     1302      +64     
==========================================
+ Hits          692      738      +46     
- Misses        510      527      +17     
- Partials       36       37       +1     
Impacted Files Coverage Δ
x/gastracker/wasmbinding/types/query.go 57.89% <57.89%> (ø)
x/gastracker/wasmbinding/types/msg.go 73.07% <73.07%> (ø)
x/gastracker/keeper/keeper.go 92.95% <82.35%> (-1.45%) ⬇️
app/app.go 90.28% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd62af...8823cad. Read the comment docs.

…a contract ability to get and update its metadata

- App keepers initialization sequence changed to support custom plugins;
- e2e tests added for the Voter contract to test bindings;
Copy link
Contributor

@edjroz edjroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edjroz edjroz merged commit f9fcee9 into main Jul 26, 2022
@edjroz edjroz deleted the wasm_bindings branch July 26, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants