Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/rewards UX #217

Merged
merged 1 commit into from
Sep 14, 2022
Merged

x/rewards UX #217

merged 1 commit into from
Sep 14, 2022

Conversation

iTiky
Copy link
Contributor

@iTiky iTiky commented Sep 12, 2022

x/rewards:

  • WithdrawRewards by limit: if a 0 limit is provided (Msg/WASM bindings), the MaxWithdrawRecords param value is used;
  • Test to define the max MaxWithdrawRecords param value is added and the default is adjusted;

@iTiky
Copy link
Contributor Author

iTiky commented Sep 12, 2022

Changes based on Augusto feedback to Frojdi

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #217 (796dc66) into main (768cbc2) will decrease coverage by 0.18%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   64.21%   64.03%   -0.19%     
==========================================
  Files          59       59              
  Lines        2356     2358       +2     
==========================================
- Hits         1513     1510       -3     
- Misses        778      783       +5     
  Partials       65       65              
Impacted Files Coverage Δ
wasmbinding/rewards/query_handler.go 69.56% <ø> (+0.59%) ⬆️
x/rewards/keeper/keeper.go 72.72% <0.00%> (-21.40%) ⬇️
x/rewards/types/msg.go 40.84% <ø> (-1.63%) ⬇️
x/rewards/types/params.go 60.37% <0.00%> (-2.37%) ⬇️
wasmbinding/rewards/msg_handler.go 77.77% <100.00%> (ø)
wasmbinding/rewards/types/msg_withdraw.go 75.00% <100.00%> (ø)
x/rewards/keeper/withdraw.go 80.00% <100.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

- WithdrawRewards by limit: if a 0 limit is provided (Msg/WASM bindings), the MaxWithdrawRecords param value is used;
- Test to define the max MaxWithdrawRecords param value is added and the default is adjusted;
- Test to define the max page limit for querying RewardsRecord objs is added and that limit is used check/create page request (Query/WASM bindings);
@iTiky iTiky merged commit f4a66ef into main Sep 14, 2022
@iTiky iTiky deleted the augusto_feedback branch September 14, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants