Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain upgradability fixes #218

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Chain upgradability fixes #218

merged 1 commit into from
Sep 19, 2022

Conversation

iTiky
Copy link
Contributor

@iTiky iTiky commented Sep 14, 2022

Storing last unique ID in a genesis for x/tracking and x/rewards objects; app EndBlocker fix

…tracking and x/rewards objects; app EndBlocker fix
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 63.98% // Head: 64.06% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (994b68a) compared to base (f4a66ef).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   63.98%   64.06%   +0.08%     
==========================================
  Files          59       59              
  Lines        2360     2382      +22     
==========================================
+ Hits         1510     1526      +16     
- Misses        784      790       +6     
  Partials       66       66              
Impacted Files Coverage Δ
x/rewards/types/genesis.go 64.81% <26.31%> (+0.98%) ⬆️
x/tracking/types/genesis.go 71.42% <55.55%> (ø)
app/app.go 91.05% <100.00%> (ø)
x/rewards/keeper/genesis.go 100.00% <100.00%> (ø)
x/rewards/keeper/invariants.go 100.00% <100.00%> (ø)
x/rewards/keeper/state_rewards_record.go 85.26% <100.00%> (-0.31%) ⬇️
x/tracking/keeper/genesis.go 100.00% <100.00%> (ø)
x/tracking/keeper/state_contract_op.go 95.18% <100.00%> (-0.12%) ⬇️
x/tracking/keeper/state_tx_info.go 95.12% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@edjroz edjroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kickass as usual 🚀 🤘

@iTiky iTiky merged commit 7c2f890 into main Sep 19, 2022
@iTiky iTiky deleted the chain_upgrade branch September 19, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants