Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rewards): adding msgSrvr and querySrvr methods for contract premiums #263

Merged
merged 8 commits into from
Feb 2, 2023

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Feb 1, 2023

Closes: #255

  • Added msgSrvr.SetFlatFee
  • Added querySrvr.FlatFee
  • Relevant tests

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 69.43% // Head: 69.41% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (b7d7209) compared to base (6fe9369).
Patch coverage: 68.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   69.43%   69.41%   -0.02%     
==========================================
  Files          61       61              
  Lines        3510     3580      +70     
==========================================
+ Hits         2437     2485      +48     
- Misses       1001     1022      +21     
- Partials       72       73       +1     
Impacted Files Coverage Δ
x/rewards/types/msg.go 41.12% <30.76%> (-2.75%) ⬇️
x/rewards/types/codec.go 52.94% <50.00%> (-0.40%) ⬇️
x/rewards/keeper/msg_server.go 96.00% <88.00%> (-4.00%) ⬇️
x/rewards/keeper/grpc_query.go 90.76% <100.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spoo-bar spoo-bar marked this pull request as ready for review February 1, 2023 16:48
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👻

@spoo-bar spoo-bar merged commit dd69fe9 into main Feb 2, 2023
@spoo-bar spoo-bar deleted the spoorthi/contract-premium-msgsrvr branch February 2, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(rewards): implement contract premiums - MsgSrvr & QuerySrvr
2 participants