-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/rewards): Contract premium - Genesis #275
feat(x/rewards): Contract premium - Genesis #275
Conversation
020c5a0
to
b374eeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Couple small changes in code organization.
Havent gone through the tests yet.
Codecov ReportBase: 69.52% // Head: 69.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 69.52% 69.88% +0.35%
==========================================
Files 61 61
Lines 3636 3692 +56
==========================================
+ Hits 2528 2580 +52
- Misses 1033 1038 +5
+ Partials 75 74 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@fdymylja Gentle reminder for review ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit and it should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you a lot!
dismissing because the concerns were addressed
Closes: #269
genesis.proto
to include flat fees data for contracts