Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/rewards): Contract premium - Genesis #275

Merged
merged 9 commits into from
Feb 15, 2023

Conversation

vidhanarya
Copy link
Contributor

Closes: #269

  • Update genesis.proto to include flat fees data for contracts
  • Update x/rewards genesis to import/export flat fees data to/from state
  • Add tests

Copy link
Contributor

@spoo-bar spoo-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Couple small changes in code organization.
Havent gone through the tests yet.

x/rewards/keeper/flat_fee.go Outdated Show resolved Hide resolved
x/rewards/keeper/flat_fee.go Outdated Show resolved Hide resolved
x/rewards/keeper/flat_fee.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 69.52% // Head: 69.88% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (695fde7) compared to base (27adc29).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   69.52%   69.88%   +0.35%     
==========================================
  Files          61       61              
  Lines        3636     3692      +56     
==========================================
+ Hits         2528     2580      +52     
- Misses       1033     1038       +5     
+ Partials       75       74       -1     
Impacted Files Coverage Δ
x/rewards/types/rewards.go 65.43% <68.75%> (+0.81%) ⬆️
x/rewards/types/genesis.go 75.28% <85.71%> (+5.94%) ⬆️
x/rewards/keeper/genesis.go 100.00% <100.00%> (ø)
x/rewards/keeper/state_flatfee.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vidhanarya
Copy link
Contributor Author

@fdymylja Gentle reminder for review ^

Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit and it should be good to go.

x/rewards/keeper/state_flatfee.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

x/rewards/keeper/state_flatfee.go Outdated Show resolved Hide resolved
@fdymylja fdymylja self-requested a review February 15, 2023 11:30
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you a lot!

@fdymylja fdymylja dismissed spoo-bar’s stale review February 15, 2023 11:31

dismissing because the concerns were addressed

@fdymylja fdymylja merged commit b2c207b into archway-network:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(rewards): implement contract premiums - genesis
3 participants