Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/rewards): Contract premium - Wasmbindings #280

Merged
merged 14 commits into from
Feb 21, 2023

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Feb 17, 2023

Closes: #279

  • Add msg plugin wasm binding for SetFlatFee
  • Add query plugin wasm binding for FlatFee
  • Wasmbindings tests
  • Updated spec
  • Updating keeper.SetFlatFee to perform the authorization check. (used to happen in msgSrvr before)

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 69.88% // Head: 69.55% // Decreases project coverage by -0.33% ⚠️

Coverage data is based on head (ad93623) compared to base (b2c207b).
Patch coverage: 57.83% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   69.88%   69.55%   -0.33%     
==========================================
  Files          61       63       +2     
  Lines        3692     3758      +66     
==========================================
+ Hits         2580     2614      +34     
- Misses       1038     1068      +30     
- Partials       74       76       +2     
Impacted Files Coverage Δ
wasmbinding/msg_plugin.go 62.96% <0.00%> (-5.04%) ⬇️
wasmbinding/query_plugin.go 78.37% <0.00%> (-4.48%) ⬇️
wasmbinding/types/msg.go 81.25% <0.00%> (-18.75%) ⬇️
wasmbinding/types/query.go 84.21% <0.00%> (-15.79%) ⬇️
wasmbinding/rewards/types/query_flatfee.go 33.33% <33.33%> (ø)
wasmbinding/rewards/types/msg_flatfee.go 40.00% <40.00%> (ø)
wasmbinding/rewards/msg_handler.go 85.71% <100.00%> (+3.36%) ⬆️
wasmbinding/rewards/query_handler.go 91.66% <100.00%> (+2.77%) ⬆️
x/rewards/keeper/flat_fee.go 100.00% <100.00%> (ø)
x/rewards/keeper/msg_server.go 100.00% <100.00%> (+4.00%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spoo-bar spoo-bar marked this pull request as ready for review February 17, 2023 15:38
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor nit on API consistency.

x/rewards/keeper/flat_fee.go Outdated Show resolved Hide resolved
@fdymylja
Copy link
Contributor

LGTM! Amazing work!

@fdymylja fdymylja merged commit cbdbf0b into main Feb 21, 2023
@fdymylja fdymylja deleted the spoorthi/contract-premiums-wasmbindings branch February 21, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(x/rewards): implement wasmbindings for querying contract flat fee
2 participants