fix(x/rewards): fixed `EstimateTxFees` error when minConsFee and contract flatfee are same denom #335

spoo-bar · 2023-04-03T15:41:37Z

Closes: #334

Fixed the sdk.Coins addition such that when both minConsFee and contract flatfee are same denom it doesnt error
Test case for this issue

codecov · 2023-04-03T15:51:34Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b88a81) 69.63% compared to head (64ae466) 69.63%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files          63       63           
  Lines        3777     3777           
=======================================
  Hits         2630     2630           
  Misses       1070     1070           
  Partials       77       77

Impacted Files	Coverage Δ
x/rewards/keeper/grpc_query.go	`91.42% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

fdymylja

Looks good TY!

…ract flatfee are same denom (#335) * fixing #334 * adding test case where mincinsfee and flat fee are same denom * adding another test case which checks just the min cons fee * Update CHANGELOG.md

spoo-bar added 4 commits April 3, 2023 16:22

fixing #333

b9d3418

adding test case where mincinsfee and flat fee are same denom

0b9fe78

adding another test case which checks just the min cons fee

38810d2

Update CHANGELOG.md

64ae466

spoo-bar requested a review from fdymylja April 3, 2023 15:41

spoo-bar changed the title ~~fixes(x/rewards): fixed EstimateTxFees error when minConsFee and contract flatfee are same denom~~ fix(x/rewards): fixed EstimateTxFees error when minConsFee and contract flatfee are same denom Apr 3, 2023

spoo-bar marked this pull request as ready for review April 3, 2023 15:50

fdymylja approved these changes Apr 3, 2023

View reviewed changes

spoo-bar merged commit 1bb75b4 into main Apr 3, 2023
8 of 9 checks passed

spoo-bar deleted the spoorthi/fix-estimate-tx-fees branch April 3, 2023 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(x/rewards): fixed `EstimateTxFees` error when minConsFee and contract flatfee are same denom #335

fix(x/rewards): fixed `EstimateTxFees` error when minConsFee and contract flatfee are same denom #335

spoo-bar commented Apr 3, 2023

codecov bot commented Apr 3, 2023

fdymylja left a comment

fix(x/rewards): fixed EstimateTxFees error when minConsFee and contract flatfee are same denom #335

fix(x/rewards): fixed EstimateTxFees error when minConsFee and contract flatfee are same denom #335

Conversation

spoo-bar commented Apr 3, 2023

codecov bot commented Apr 3, 2023

Codecov Report

fdymylja left a comment

Choose a reason for hiding this comment

fix(x/rewards): fixed `EstimateTxFees` error when minConsFee and contract flatfee are same denom #335

fix(x/rewards): fixed `EstimateTxFees` error when minConsFee and contract flatfee are same denom #335