Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/rewards): add minimum price of gas #351

Merged
merged 4 commits into from
May 5, 2023
Merged

feat(x/rewards): add minimum price of gas #351

merged 4 commits into from
May 5, 2023

Conversation

fdymylja
Copy link
Contributor

@fdymylja fdymylja commented May 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 64.28% and project coverage change: -0.14 ⚠️

Comparison is base (41e94e4) 69.53% compared to head (a46851a) 69.39%.

❗ Current head a46851a differs from pull request most recent head 0f8a9fd. Consider uploading reports for the commit 0f8a9fd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   69.53%   69.39%   -0.14%     
==========================================
  Files          65       65              
  Lines        3821     3843      +22     
==========================================
+ Hits         2657     2667      +10     
- Misses       1082     1090       +8     
- Partials       82       86       +4     
Impacted Files Coverage Δ
x/rewards/ante/ante_utils.go 69.69% <ø> (ø)
x/rewards/types/params.go 55.31% <41.17%> (-3.66%) ⬇️
x/rewards/keeper/min_cons_fee.go 69.23% <44.44%> (-5.19%) ⬇️
x/rewards/ante/min_cons_fee.go 84.21% <100.00%> (+5.63%) ⬆️
x/rewards/keeper/grpc_query.go 91.17% <100.00%> (-0.26%) ⬇️
x/rewards/keeper/params.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanicar zanicar merged commit 92abf73 into main May 5, 2023
7 checks passed
@zanicar zanicar deleted the fdymylja/pog branch May 5, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants