Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: titus deployment fix #380

Merged
merged 4 commits into from
May 11, 2023
Merged

fix: titus deployment fix #380

merged 4 commits into from
May 11, 2023

Conversation

jlehtimaki
Copy link
Contributor

this PR fixes deployment issue on titus, which was caused by not getting proper short sha.
also includes small fixes to manifest naming scheme

@jlehtimaki jlehtimaki requested a review from a team as a code owner May 11, 2023 06:55
@jlehtimaki jlehtimaki requested a review from loverdos May 11, 2023 06:55
shahbazn
shahbazn approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@shahbazn shahbazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shahbazn shahbazn merged commit 7cde14d into main May 11, 2023
5 checks passed
@shahbazn shahbazn deleted the titus_deployment_fix branch May 11, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahbazn shahbazn shahbazn approved these changes

@loverdos loverdos Awaiting requested review from loverdos loverdos is a code owner automatically assigned from archway-network/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlehtimaki @shahbazn