Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added openapi.yml ➕ Generate openapi.yml on proto-swagger-gen #395

Merged
merged 4 commits into from
May 29, 2023
Merged

feat: Added openapi.yml ➕ Generate openapi.yml on proto-swagger-gen #395

merged 4 commits into from
May 29, 2023

Conversation

spoo-bar
Copy link
Contributor

  • Added openapi.yml which can be hosted by nodes to serve swagger UIs
  • Modified make proto-swagger-gen to also generate the openapi.yml file

@spoo-bar spoo-bar marked this pull request as ready for review May 29, 2023 16:08
@spoo-bar spoo-bar requested a review from a team as a code owner May 29, 2023 16:08
zanicar
zanicar approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanicar zanicar merged commit 713ab73 into main May 29, 2023
5 checks passed
@zanicar zanicar deleted the spoorthi/swagger-update branch May 29, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanicar zanicar zanicar approved these changes

@aelesbao aelesbao Awaiting requested review from aelesbao aelesbao is a code owner automatically assigned from archway-network/protocol

@jlehtimaki jlehtimaki Awaiting requested review from jlehtimaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spoo-bar @zanicar