Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add upgrade handler for 0.6 back #406

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

zanicar
Copy link
Contributor

@zanicar zanicar commented Jun 21, 2023

This should address the issue where --skip-upgrade-handler still results in a panic, as CosmosSDK is checking for a downgraded binary... thus the last applied upgrade will always be needed even when using --skip-upgrade-handler;

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.17 🎉

Comparison is base (9331635) 69.17% compared to head (dc49084) 69.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   69.17%   69.34%   +0.17%     
==========================================
  Files          67       67              
  Lines        3980     3980              
==========================================
+ Hits         2753     2760       +7     
+ Misses       1130     1124       -6     
+ Partials       97       96       -1     
Impacted Files Coverage Δ
app/app_upgrades.go 61.90% <ø> (+33.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zanicar zanicar marked this pull request as ready for review June 21, 2023 09:37
@zanicar zanicar requested a review from a team as a code owner June 21, 2023 09:37
@zanicar zanicar requested a review from loverdos June 21, 2023 09:37
@zanicar zanicar merged commit 5ffe188 into main Jun 21, 2023
6 checks passed
@zanicar zanicar deleted the zanicar/fix-upgrade-handler branch June 21, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants