Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 support #18

Merged
merged 1 commit into from Mar 14, 2016
Merged

PHP7 support #18

merged 1 commit into from Mar 14, 2016

Conversation

umpirsky
Copy link
Contributor

No description provided.

@umpirsky umpirsky changed the title [WIP] PHP7 support PHP7 support Jan 18, 2016
@archwisp
Copy link
Owner

Thanks for the PR! Unfortunately, the build is now failing because Coveralls seems to require 5.5+ but the library supports 5.3+. If you can find a way to get the build to pass with 5.3+ (probably pin the Coveralls version), I can merge the request.

@umpirsky
Copy link
Contributor Author

@archwisp We should use "satooshi/php-coveralls": "~1.0" since it supports PHP 5.3, not dev-master. Any reason to use dev-master?

I tried to use "satooshi/php-coveralls": "~1.0", but I got:

$ composer update satooshi/php-coveralls
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing symfony/yaml (v2.8.2)
    Downloading: 100%         

  - Installing symfony/stopwatch (v3.0.1)
    Loading from cache

  - Installing symfony/polyfill-mbstring (v1.0.1)
    Loading from cache

  - Installing symfony/console (v3.0.1)
    Loading from cache

  - Installing symfony/filesystem (v3.0.1)
    Loading from cache

  - Installing symfony/config (v3.0.1)
    Downloading: 100%         

  - Installing psr/log (1.0.0)
    Loading from cache

  - Installing symfony/event-dispatcher (v2.8.2)
    Downloading: 100%         

  - Installing guzzle/guzzle (v3.9.3)
    Loading from cache

  - Installing satooshi/php-coveralls (v1.0.0)
    Downloading: 100%         

  - Installing phpunit/php-text-template (1.2.1)
    Loading from cache

  - Installing phpunit/phpunit-mock-objects (1.2.3)
    Loading from cache

  - Installing phpunit/php-timer (1.0.7)
    Loading from cache

  - Installing phpunit/php-token-stream (1.2.2)
    Loading from cache

  - Installing phpunit/php-file-iterator (1.4.1)
    Loading from cache

  - Installing phpunit/php-code-coverage (1.2.18)
    Downloading: 100%         

  - Installing phpunit/phpunit (3.7.38)
    Downloading: 100%         

symfony/console suggests installing symfony/process ()
symfony/event-dispatcher suggests installing symfony/dependency-injection ()
symfony/event-dispatcher suggests installing symfony/http-kernel ()
guzzle/guzzle suggests installing guzzlehttp/guzzle (Guzzle 5 has moved to a new package name. The package you have installed, Guzzle 3, is deprecated.)
satooshi/php-coveralls suggests installing symfony/http-kernel (Allows Symfony integration)
phpunit/phpunit suggests installing phpunit/php-invoker (~1.1)
Writing lock file
Generating autoload files
Warning: Ambiguous class resolution, "PHPCS_Sniffs_ControlStructures_ControlSignatureSniff" was found in both "vendor/phpunit/phpunit/build/PHPCS/Sniffs/ControlStructures/ControlSignatureSniff.php" and "vendor/phpunit/php-token-stream/build/PHPCS/Sniffs/ControlStructures/ControlSignatureSniff.php", the first will be used.
Warning: Ambiguous class resolution, "PHPCS_Sniffs_Whitespace_ConcatenationSpacingSniff" was found in both "vendor/phpunit/phpunit/build/PHPCS/Sniffs/Whitespace/ConcatenationSpacingSniff.php" and "vendor/phpunit/php-token-stream/build/PHPCS/Sniffs/Whitespace/ConcatenationSpacingSniff.php", the first will be used.
Warning: Ambiguous class resolution, "PHPCS_Sniffs_ControlStructures_ControlSignatureSniff" was found in both "vendor/phpunit/phpunit/build/PHPCS/Sniffs/ControlStructures/ControlSignatureSniff.php" and "vendor/phpunit/php-code-coverage/build/PHPCS/Sniffs/ControlStructures/ControlSignatureSniff.php", the first will be used.
Warning: Ambiguous class resolution, "PHPCS_Sniffs_Whitespace_ConcatenationSpacingSniff" was found in both "vendor/phpunit/phpunit/build/PHPCS/Sniffs/Whitespace/ConcatenationSpacingSniff.php" and "vendor/phpunit/php-code-coverage/build/PHPCS/Sniffs/Whitespace/ConcatenationSpacingSniff.php", the first will be used.
Warning: Ambiguous class resolution, "PHPCS_Sniffs_ControlStructures_ControlSignatureSniff" was found in both "vendor/phpunit/phpunit/build/PHPCS/Sniffs/ControlStructures/ControlSignatureSniff.php" and "vendor/phpunit/phpunit-mock-objects/build/PHPCS/Sniffs/ControlStructures/ControlSignatureSniff.php", the first will be used.
Warning: Ambiguous class resolution, "PHPCS_Sniffs_Whitespace_ConcatenationSpacingSniff" was found in both "vendor/phpunit/phpunit/build/PHPCS/Sniffs/Whitespace/ConcatenationSpacingSniff.php" and "vendor/phpunit/phpunit-mock-objects/build/PHPCS/Sniffs/Whitespace/ConcatenationSpacingSniff.php", the first will be used.

Why do we need "classmap": [""],?

@johnkary
Copy link
Collaborator

@umpirsky Thanks for the PR! I opened the following PRs to fix the issues you found:

#19 - Remove classmap from Composer config
#20 - Pin satooshi/php-coveralls to PHP 5.3+ compatible version

Once those are merged we can rebase against master to see your PR's updated Travis runs.

@umpirsky
Copy link
Contributor Author

@johnkary Wow, that was fast! :trollface:

However, better ever then never. :)

archwisp added a commit that referenced this pull request Mar 14, 2016
@archwisp archwisp merged commit 05bbf82 into archwisp:master Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants