Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate calling protect() with no rules configured in the SDK #605

Closed
blaine-arcjet opened this issue Apr 16, 2024 · 0 comments · Fixed by #608
Closed

Deprecate calling protect() with no rules configured in the SDK #605

blaine-arcjet opened this issue Apr 16, 2024 · 0 comments · Fixed by #608
Assignees
@blaine-arcjet

Comments

@blaine-arcjet
Copy link
Contributor

Currently, calling protect() with no rules configured in the SDK will still run the Shield rule implicitly in Arcjet's Decide service.

We are deprecating the implicitness of Shield, so we'll want to warn if protect() is called with no rules. After the deprecation phase, this may turn into an explicit error.
@blaine-arcjet blaine-arcjet self-assigned this Apr 16, 2024
This was referenced Apr 16, 2024
Open
Merged
@trunk-io trunk-io bot closed this as completed in #608 Apr 16, 2024
trunk-io bot pushed a commit that referenced this issue Apr 16, 2024
@blaine-arcjet
chore!: Deprecate calling protect() with no rules (#608)
57a8f6b 
Closes #605 

This adds a warning log if `protect()` is called with no rules configured that lets users know they should be configuring at least one rule, and suggests Shield because that is the common case where no rule would be specified before this behavior change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blaine-arcjet blaine-arcjet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: Deprecate calling protect() with no rules arcjet/arcjet-js
1 participant
@blaine-arcjet