Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): Fix the issue with page being 0 #2828

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

wsw2000
Copy link
Contributor

@wsw2000 wsw2000 commented Nov 25, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

翻页器组件的page应该是从1开始的正整数,因为它代表的是当前页码。如果page为0,可能会导致一些错误或者不符合预期的结果,感觉page不应该设置为0把

Solution

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
Pagination 修复页码可能为 0 的问题 Fix the problem that the page number may be 0 Close #2827

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion flsion added this to the 2.54.0 milestone Dec 15, 2023
@flsion flsion added the type: 🐞 bug Something isn't working label Dec 15, 2023
@flsion flsion merged commit 2104cd9 into arco-design:main Dec 15, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🐞 bug Something isn't working
Projects
None yet
2 participants