Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): fix overlapping styles of neighboring components in input-group #2889

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

Summer-Shen
Copy link
Contributor

@Summer-Shen Summer-Shen commented Dec 27, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

Solution

修改了 input 组件的部分 z-indexborder-right-color 属性

How is the change tested?

  • 由于暂时未能在 acro-design-vue 使用线性主题,通过本地修改一些 vars 验证了提交的效果
  • 更新了 input 测试用例

Changelog

Component Changelog(CN) Changelog(EN) Related issues
input 修复 input-group 相邻组件样式叠加时的问题 Fix overlapping styles of neighboring components in input-group Close #1737 , Close #1758

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

如果之后本地能引入线性主题复现问题,可能会进一步修改

@Summer-Shen Summer-Shen changed the title Fix/input group style fix(input): fix overlapping styles of neighboring components in input-group Dec 27, 2023
@flsion flsion assigned flsion and unassigned flsion Jan 11, 2024
@flsion flsion added the type: 🔮 style Something about component style label Jan 11, 2024
@flsion flsion added this to the 2.54.2 milestone Jan 11, 2024
@flsion
Copy link
Member

flsion commented Jan 11, 2024

@Summer-Shen 这个 PR 我本地测试了一下,线框模式还是会有问题,不过提供了一个很好的思路,我再完善一下

@flsion flsion merged commit 815234f into arco-design:main Jan 11, 2024
@flsion
Copy link
Member

flsion commented Jan 11, 2024

related #2917

@Summer-Shen Summer-Shen deleted the fix/input-group-style branch March 26, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🔮 style Something about component style
Projects
None yet
2 participants