Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color-picker): add color-picker component #2958

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Feb 1, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

颜色选择器 ColorPicker

Solution

代码主逻辑 / 风格样式 与 React 版颜色选择器一致。

API:
image
image

iShot_2024-02-02_00.08.10.mp4

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
color-picker 新增颜色选择器 add color-picker component Closes #2951, Closes #2752, Closes #2383

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion
Copy link
Member

flsion commented Feb 2, 2024

@LIjiAngChen8 强👍🏻

@flsion flsion self-assigned this Feb 2, 2024
@flsion flsion added the type: feature request New feature or request label Feb 2, 2024
@flsion flsion added this to the 2.55.0 milestone Feb 2, 2024
@Loongphy
Copy link
Contributor

Loongphy commented Feb 8, 2024

快男

@Free0520
Copy link

可以增加一个吸管功能吗,或者给个插槽 @flsion

@flsion
Copy link
Member

flsion commented Mar 15, 2024

可以增加一个吸管功能吗,或者给个插槽 @flsion

下个版本会加个自定义插槽

@flsion flsion merged commit d8ae3f9 into arco-design:main Mar 15, 2024
2 of 4 checks passed
@chenbimo
Copy link

好像还没在文档中看到这个组件,这个很不错,希望增加更多组件,感谢团队的辛苦工作~

@3529
Copy link

3529 commented Mar 18, 2024

颜色选择器貌似有BUG。双向绑定有问题,比如对颜色进行赋值,界面无更新。

<template>
  <a-space>
    <a-color-picker v-model="value" />
    {{ value }}

  </a-space>
</template>

<script setup>
import { ref } from 'vue';
const value = ref('#165DFF');
setTimeout(() => {
  value.value = '#ff5500';
}, 500);
</script>

@kellehod
Copy link

颜色选择器貌似有BUG。双向绑定有问题,比如对颜色进行赋值,界面无更新。

<template>
  <a-space>
    <a-color-picker v-model="value" />
    {{ value }}

  </a-space>
</template>

<script setup>
import { ref } from 'vue';
const value = ref('#165DFF');
setTimeout(() => {
  value.value = '#ff5500';
}, 500);
</script>

也遇到了这个问题

@lw9810
Copy link

lw9810 commented Apr 7, 2024

import { defineComponent } from 'vue';

export default defineComponent({
setup() {
const colorCode = ref('#ff5500');
return () => (
<>

</>
);
}
});
对颜色进行双向绑定的时候初始视图不变,单独设置default-value 有效 ,设置default-value 同时双向绑定初始视图不变

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

可以加个颜色选择器吗 能添加一个颜色选择器吗 希望增加 颜色选择器 组件
8 participants