Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): fix v-model not working #2961

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Feb 4, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

在 PR #2915 的变更时影响到了 model-event 为 change 时更新 modelValue 的时机(双向绑定失效)。

Solution

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
input-number 修复双向绑定失效 fix v-model not working Closes #2959, Closes #2965, Closes #2981, Closes #2983

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@oljc oljc added the type: 🐞 bug Something isn't working label Feb 4, 2024
@oljc
Copy link
Member Author

oljc commented Feb 6, 2024

@flsion 这个可能需要早些处理一下

@oljc oljc changed the title fix(input-number): fix lack of validation after value change fix(input-number): fix v-model not working Feb 21, 2024
@flsion flsion self-assigned this Feb 21, 2024
@flsion flsion added this to the 2.54.5 milestone Feb 21, 2024
@flsion flsion merged commit 4c25475 into arco-design:main Feb 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment