Add default template support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used for `bonnie --init`. It fetches the file at `$BONNIE_TEMPLATE_PATH`, falling back to `~/.bonnie/template.toml` if necessary. The `home` crate was introduced to handle the finding of the user's home directory on Windows, which is surprisingly complicated and **can fail**.
Using the `-e` or `--edit-template` flag, the user can now open the template file using the editor in the `EDITOR` environment variable or, on Windows, `start`.
It is now `BONNIE_TEMPLATE` to match `BONNIE_CONFIG`. This breaks with the previous implementation.
Changed `BONNIE_TEMPLATE_PATH` to `BONNIE_TEMPLATE`.
arctic-hen7
requested changes
Jul 12, 2021
There was a problem hiding this comment.
This looks really great! Just a few minor things. The only main issues are that I'd like you to create string errors at the site of the error and then propagate those up to main, rather than returning any unparsed errors. Also, if you could move the -e code out of main.rs and into it's own file for testing, that'd be great.
I'm happy if this particular PR doesn't include testing, I can write tests for the features afterward.
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Copying a file doesn't take that long.
It added quotes around a string.
arctic-hen7
requested changes
Jul 12, 2021
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
Co-authored-by: arctic_hen7 <arctic_hen7@pm.me>
|
Just that |
arctic-hen7
requested changes
Jul 12, 2021
|
Thank you very much for your contribution @ostev! It's greatly appreciated! |
arctic-hen7
added a commit
that referenced
this pull request
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16.
I pulled in the
homecrate to handle getting the home directory on Windows, which appears to require interacting with Win32 APIs.